Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: add some comments about intended use of ChunkedStore #4541

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 7, 2022

Which issue does this PR close?

N/A

Rationale for this change

There appeared to be confusion (maybe meta confusion) about the usecase for ChunkedStream on #4525

What changes are included in this PR?

Add some docstrings (adapted from @tustvold and @metesynnada 's comments on #4525) to ChunkedStore

Are these changes tested?

Docstring only tests

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Dec 7, 2022
@tustvold
Copy link
Contributor

tustvold commented Dec 7, 2022

Thank you

@tustvold tustvold merged commit 4c1f60c into apache:master Dec 7, 2022
@ursabot
Copy link

ursabot commented Dec 7, 2022

Benchmark runs are scheduled for baseline = 5f74284 and contender = 4c1f60c. 4c1f60c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/chunked_store_comments branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants