refactor: make Ctes a struct to also store data types provided by prepare stmt #4520
Conversation
github-actions
bot
added
core
| /// Create a new Ctes | ||
| pub fn new() -> Self { | ||
| Self { | ||
| prepare_param_data_types: vec![], |
There was a problem hiding this comment.
This is always empty in this PR. After this is merged, I will use and set it in PR #4490
|
Look like |
I have retriggered -- hopefully it will complete soon |
|
Thanks @alamb and @jackwener. I have addressed all your comments. |
|
Benchmark runs are scheduled for baseline = d9a47d6 and contender = bfd41a3. bfd41a3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
While working on PR #4490 that implements
PREPARE stmt, I found that I need to pass the provided data types of the parameters/binding down to the plan's expressions to map data types to $1, $2, ...@alamb has suggested me to pass datatypes of the parameters along with the CTEs. This PR is just a refactor to convert
ctesfrom a hash map to a struct that store both ctes (hahhmap) and the params' data types.