Make window function related struct public for ballista. #4511
Conversation
Signed-off-by: yangjiang <[email protected]>
| pub use crate::window::lead_lag::{lag, lead}; | ||
| pub use crate::window::nth_value::NthValue; | ||
| pub use crate::window::nth_value::{NthValue, NthValueKind}; |
There was a problem hiding this comment.
Although the struct is public, but the mod is private. So i decide public less, only the needed struct.
|
|
||
| /// Get aggregate expr of AggregateWindowExpr | ||
| pub fn get_aggregate_expr(&self) -> &Arc<dyn AggregateExpr> { | ||
| &self.aggregate |
There was a problem hiding this comment.
get_aggregate_expr and get_built_in_func_expr return diff trait object , i think can not extract them in WindowExpr
|
Benchmark runs are scheduled for baseline = 34d9bb5 and contender = 73527e3. 73527e3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Signed-off-by: yangjiang [email protected]
Which issue does this PR close?
Closes #4479 .
Rationale for this change
Enable window func in ballista.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?