Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sqllogictests CI run #4504

Merged
merged 1 commit into from
Dec 4, 2022

Conversation

mvanschellebeeck
Copy link
Contributor

There's no need for a separate CI run as sqllogictests already run as part of cargo test here: https://github.com/apache/arrow-datafusion/blob/master/.github/workflows/rust.yml#L71

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@alamb alamb mentioned this pull request Dec 4, 2022
28 tasks
@alamb alamb merged commit 055ffa4 into apache:master Dec 4, 2022
@mvanschellebeeck mvanschellebeeck deleted the mv/remove-sqllogictests-ci branch December 4, 2022 16:00
@ursabot
Copy link

ursabot commented Dec 4, 2022

Benchmark runs are scheduled for baseline = a2bc499 and contender = 055ffa4. 055ffa4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants