Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty string normalization to sqllogictests #4501

Merged
merged 2 commits into from
Dec 4, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 4, 2022

Which issue does this PR close?

Part of apache/arrow-rs#3268

Rationale for this change

Follow the DuckDB semantics (so we can eventually reuse some/all of their tests) https://duckdb.org/dev/sqllogictest/result_verification#null-values-and-empty-strings

What changes are included in this PR?

Normalize empty strings to (empty)

Note that I can't normalize nulls to NULL without apache/arrow-rs#3268

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Dec 4, 2022
@alamb alamb force-pushed the alamb/normalize_strings branch from 82574ae to 6fe55ab Compare December 4, 2022 13:46
@alamb alamb marked this pull request as ready for review December 4, 2022 15:05
@alamb
Copy link
Contributor Author

alamb commented Dec 4, 2022

fyi @xudong963 and @mvanschellebeeck

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit a2bc499 into apache:master Dec 4, 2022
@alamb alamb deleted the alamb/normalize_strings branch December 4, 2022 15:56
@ursabot
Copy link

ursabot commented Dec 4, 2022

Benchmark runs are scheduled for baseline = b5b50ba and contender = a2bc499. a2bc499 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants