-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqllogictest: A logging and command line filter #4497
Conversation
18bec3b
to
42af19e
Compare
cc @xudong963 and @mvanschellebeeck |
nice - thanks @alamb! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This a very nice feature, we don't need to run all tests each time. Thank you @alamb
Benchmark runs are scheduled for baseline = 237233f and contender = 2a754f8. 2a754f8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
re #4460
Rationale for this change
While debugging a sqllogictest I would like to run a single file at a time rather than all in the directory. I would also like the ability to see debug logs, etc, etc
What changes are included in this PR?
env_logger
so settingRUST_LOG
is resptedNote, I did not bring in Clap or some other full featured command line parser. I figured if/when we need the ability to add more flags, we could bring it in.
Also I tried to avoid making changes that would conflict with #4496 from @xudong963
Are these changes tested?
Are there any user-facing changes?
No
Examples
Example running with just one file:
Example with logging: