Remove the schema checking when creating CrossJoinExec
#4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
andygrove
reviewed
Nov 30, 2022
Comment on lines
+67
to
75
| let all_columns = { | ||
| let left_schema = left.schema(); | ||
| let right_schema = right.schema(); | ||
| let left_fields = left_schema.fields().iter(); | ||
| let right_fields = right_schema.fields().iter(); | ||
| left_fields.chain(right_fields).cloned().collect() | ||
| }; | ||
|
|
||
| let schema = Arc::new(Schema::new(all_columns)); |
There was a problem hiding this comment.
Could you use Schema::merge here instead?
There was a problem hiding this comment.
You could do something like this. This would preserve schema metadata as well.
let input_schemas = vec![left.schema().as_ref().clone(), right.schema().as_ref().clone()];
let schema = Arc::new(Schema::try_merge(input_schemas)?);There was a problem hiding this comment.
Sorry, I'm afraid try_merge doesn't fit this context.
What we want here is to concatenate schema, but not merge schema. It could happen that a table cross joins with itself, or two tables have same named columns, in which cases, merge doesn't work.
There was a problem hiding this comment.
For the metadata, we should also do concatenation, instead of merging.
There was a problem hiding this comment.
@andygrove, what's your suggestion?
alamb
approved these changes
Dec 9, 2022
|
As I think all comments have been addressed, I am merging it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi [email protected]
Which issue does this PR close?
Closes #4431 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Yes, rename
CrossJoinExec::try_newtoCrossJoinExec::newand update the return type toSelf.