Reduce repetition in Decimal binary kernels, upgrade to arrow 11.1 #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Mar 28, 2022
| } | ||
| } | ||
| Ok(bool_builder.finish()) | ||
| compare_decimal_scalar(left, right, |left, right| left == right) |
There was a problem hiding this comment.
This PR simply refactors out the common iteration over inputs into compare_decimal and compare_decimal_scalar
|
FYI @liukun4515 |
alamb
force-pushed
the
alamb/cleanup_binary
branch
from
af284b0 to
45758eb
Compare
|
Draft until I can debug CI failure |
This was referenced Mar 29, 2022
|
Blocked by upstream issue in arrow-rs: apache/arrow-rs#1506 |
liukun4515
reviewed
Mar 30, 2022
| { | ||
| Ok(left | ||
| .iter() | ||
| .map(|left| left.map(|left| op(left, right))) |
There was a problem hiding this comment.
Does this iter need sized？
There was a problem hiding this comment.
I think the call to collect() eventually needs the iterator to be sized (so it knows how large an array to allocate)
alamb
force-pushed
the
alamb/cleanup_binary
branch
from
45758eb to
3c582d1
Compare
alamb
changed the title
yjshen
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
I noticed some things that could be written "more nicely" while trolling through the code for other reasons and figured I would sneak in some coding (rather than review)
I think this also makes it easier to port this code to arrow-rs eventually: apache/arrow-rs#1200
Changes:
11.1as it requires Implementsize_hintandExactSizedIteratorforDecimalArrayarrow-rs#1506