-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more ScalarFunction in Ballista #2008
Conversation
Thanks, @Ted-Jiang I will go through this pr later. |
@@ -979,8 +1008,6 @@ impl TryFrom<&protobuf::LogicalExprNode> for Expr { | |||
ScalarFunction::Sin => Ok(sin((&args[0]).try_into()?)), | |||
ScalarFunction::Cos => Ok(cos((&args[0]).try_into()?)), | |||
ScalarFunction::Tan => Ok(tan((&args[0]).try_into()?)), | |||
// ScalarFunction::Asin => Ok(asin(&args[0]).try_into()?)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the commented-out Asin, Acos, Concat, Array, Nullif, and md5 are removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opps, forgot the deleted line, have added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's would be better if we had the tests for the build-in function on the ballista side.
@Ted-Jiang Can you help to add some tests for this in the follow-up pull request?
may need a follow-up pr when #1969 merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ted-Jiang, LGTM.
Which issue does this PR close?
Closes #2007 .
Rationale for this change
Now support more
ScalarFunction
in ballista. like "random"start 1 scheduler + 1 executor
run client with
cargo run --features=ballista --bin datafusion-cli -- --host localhost --port 50050
Before:
Now:
What changes are included in this PR?
Are there any user-facing changes?