-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ballista] Add Decimal128, Date64, TimestampSecond, TimestampMillisecond, Interv… #1659
Conversation
…alYearMonth, IntervalDayTime to proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cc @realno @yahoNanJing
@houqp I will review this carefully later |
Why the windows check failed ? Is there some idea to fix it? |
https://github.com/apache/arrow-datafusion/runs/4919106498?check_suite_focus=true
This looks like a bug in the I think it will pass on a rerun -- I retriggered he check and hopefully it will pass this time |
Yes. It's ok now. Thanks |
LGTM |
Thanks @realno and @gaojun2048 |
close #1658