Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ballista] Add Decimal128, Date64, TimestampSecond, TimestampMillisecond, Interv… #1659

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

EricJoy2048
Copy link
Member

close #1658

Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houqp houqp added the enhancement New feature or request label Jan 24, 2022
@liukun4515
Copy link
Contributor

@houqp I will review this carefully later

@EricJoy2048
Copy link
Member Author

EricJoy2048 commented Jan 24, 2022

Why the windows check failed ? Is there some idea to fix it?

@alamb
Copy link
Contributor

alamb commented Jan 24, 2022

https://github.com/apache/arrow-datafusion/runs/4919106498?check_suite_focus=true

error[E0308]: mismatched types
   --> C:\Users\runneradmin\.cargo\registry\src\github.jparrowsec.cn-1ecc6299db9ec823\which-4.2.3\src\finder.rs:161:65
    |
161 | ...                   if s.as_bytes().first() == Some(b'.') {
    |                                                       ^^^^
    |                                                       |
    |                                                       expected `&u8`, found `u8`
    |                                                       help: consider borrowing here: `&b'.'`

For more information about this error, try `rustc --explain E0308`.
error: could not compile `which` due to previous error

This looks like a bug in the which crate which was fixed: harryfei/which-rs@4.2.3...4.2.4

I think it will pass on a rerun -- I retriggered he check and hopefully it will pass this time

@EricJoy2048
Copy link
Member Author

EricJoy2048 commented Jan 25, 2022

https://github.com/apache/arrow-datafusion/runs/4919106498?check_suite_focus=true

error[E0308]: mismatched types
   --> C:\Users\runneradmin\.cargo\registry\src\github.jparrowsec.cn-1ecc6299db9ec823\which-4.2.3\src\finder.rs:161:65
    |
161 | ...                   if s.as_bytes().first() == Some(b'.') {
    |                                                       ^^^^
    |                                                       |
    |                                                       expected `&u8`, found `u8`
    |                                                       help: consider borrowing here: `&b'.'`

For more information about this error, try `rustc --explain E0308`.
error: could not compile `which` due to previous error

This looks like a bug in the which crate which was fixed: harryfei/[email protected]

I think it will pass on a rerun -- I retriggered he check and hopefully it will pass this time

Yes. It's ok now. Thanks

@realno
Copy link
Contributor

realno commented Jan 25, 2022

LGTM

@alamb alamb merged commit bf68073 into apache:master Jan 25, 2022
@alamb
Copy link
Contributor

alamb commented Jan 25, 2022

Thanks @realno and @gaojun2048

@EricJoy2048 EricJoy2048 deleted the add_more_datatype_to_proto branch February 7, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ballista] Add more datatype to proto
5 participants