Multiple ways to express like
/ ilike
/ not like
/ not ilike
#4765
Labels
bug
Something isn't working
good first issue
Good for newcomers
logical-expr
Logical plan and expressions
Describe the bug
There are two ways to express pattern matching in datafusion Exprs.
https://github.com/apache/arrow-datafusion/blob/3abbffb5c83395e8e6e68e5529835e72e7769d0d/datafusion/expr/src/operator.rs#L55-L61
As well as
This causes issues such as the simplification in #4646 only affects the BinaryExpr form, not the Expr::Like form
The
Expr::Like
form is more full featured (can have pattern substitution)Expected behavior
I would like to have a single way to represent these operators. I believe it should be
Expr::Like
,Expr::ILike
,Expr::NotLike
andExpr::NotILike
as they have more features.Thus, I would like to remove
Operator::Like
,Operator::ILike
,Operator::NotLike
, andOperator::NotILike
and update all tests / code to use Expr::LikeAdditional context
Noticed while reviewing #4646 from @crepererum
I am marking this as "good first issue" as it is mostly a software engineering exercise and would be guided by the compiler -- it would be a good exercise to get familiar with DataFusion's codebase
The text was updated successfully, but these errors were encountered: