Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LogicalPlanBuilder Consuming #4622

Closed
tustvold opened this issue Dec 14, 2022 · 0 comments · Fixed by #4632
Closed

Make LogicalPlanBuilder Consuming #4622

tustvold opened this issue Dec 14, 2022 · 0 comments · Fixed by #4632
Assignees
@tustvold
Labels
enhancement New feature or request

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Similar to #4621 the current LogicalPlanBuilder API is non-consuming, and non-mutating. This consequently results in a large number of unnecessary clones of LogicalPlan which are not necessarily cheap.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement New feature or request label Dec 14, 2022
@tustvold tustvold self-assigned this Dec 14, 2022
@tustvold tustvold mentioned this issue Dec 14, 2022
Closed
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Dec 14, 2022
@tustvold
Make LogicalPlanBuilder consuming (apache#4622)
ca93d5b
@tustvold tustvold mentioned this issue Dec 14, 2022
Merged
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Dec 14, 2022
@tustvold
Make LogicalPlanBuilder consuming (apache#4622)
836a0cf
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Dec 14, 2022
@tustvold
Make LogicalPlanBuilder consuming (apache#4622)
b446e6d
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Dec 15, 2022
@tustvold
Make LogicalPlanBuilder consuming (apache#4622)
494d747
tustvold added a commit that referenced this issue Dec 16, 2022
@tustvold
Make LogicalPlanBuilder consuming (#4622) (#4632)
2e9eea4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make LogicalPlanBuilder consuming (#4622) tustvold/arrow-datafusion
1 participant
@tustvold