Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DataFrame Consuming #4621

Closed
tustvold opened this issue Dec 14, 2022 · 0 comments · Fixed by #4624
Closed

Make DataFrame Consuming #4621

tustvold opened this issue Dec 14, 2022 · 0 comments · Fixed by #4624
Assignees
@tustvold
Labels
enhancement New feature or request

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently all of the various methods on DataFrame take &self, and a number of methods return Arc<DataFrame>.

This results in a non-trivial amount of unnecessary clones, in particular of LogicalPlan which is not especially cheap.

Describe the solution you'd like

I would like methods to return DataFrame instead of Arc<DataFrame> and for the member functions on DataFrame to capture self

Describe alternatives you've considered

Additional context
Add any other context or screenshots about the feature request here.
@tustvold tustvold added the enhancement New feature or request label Dec 14, 2022
@tustvold tustvold changed the title DataFrame Consuming Make DataFrame Consuming Dec 14, 2022
@tustvold tustvold mentioned this issue Dec 14, 2022
Closed
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Dec 14, 2022
@tustvold
Make DataFrame API consuming (apache#4621)
af00821
@tustvold tustvold mentioned this issue Dec 14, 2022
Merged
@tustvold tustvold self-assigned this Dec 14, 2022
@tustvold tustvold mentioned this issue Dec 14, 2022
Closed
tustvold added a commit that referenced this issue Dec 15, 2022
@tustvold
Make DataFrame API consuming (#4621) (#4624)
5c558e9 
* Make DataFrame API consuming (#4621)

* Fix doc

* More methods

* Fix doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make DataFrame API consuming (#4621) tustvold/arrow-datafusion
1 participant
@tustvold