Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the schema checking from CrossJoinExec::try_new #4431

Closed
HaoYang670 opened this issue Nov 30, 2022 · 0 comments · Fixed by #4432
Closed

Remove the schema checking from CrossJoinExec::try_new #4431

HaoYang670 opened this issue Nov 30, 2022 · 0 comments · Fixed by #4432
Labels
enhancement New feature or request

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
https://github.com/apache/arrow-datafusion/blob/49166ea55f317722ab7a37fbfc253bcd497c1672/datafusion/core/src/physical_plan/joins/cross_join.rs#L67-L92
We don't need to check the schemas when doing cross join because the join key is always empty.

Describe the solution you'd like
Remove the checking and update the return type of the function. Also, it is better to rename the function as new

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
We could not do this.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant