Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce usage of IntoIterator<Item = Expr> in logical plan builder window fn #372

Closed
jimexist opened this issue May 21, 2021 · 0 comments
Closed

Comments

@jimexist
Copy link
Member

I am not sure we should use IntoIterator<Item = Expr> for every field with 6 fields. This will produce a version of the compiled function for every combination, which IMO adds an unnecessary compile time and binary size.

IntoIterator is more relevant when we want to avoid an extra allocation; these are very small vectors.

Originally posted by @jorgecarleitao in #334 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant