Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[follow up]cleaning up statements.remove(0) #1986

Closed
doki23 opened this issue Mar 11, 2022 · 0 comments · Fixed by #2017
Closed

[follow up]cleaning up statements.remove(0) #1986

doki23 opened this issue Mar 11, 2022 · 0 comments · Fixed by #2017

Comments

@doki23
Copy link
Contributor

doki23 commented Mar 11, 2022

i can approve to unblock merging but i do think the remove(0) makes the logic quite cryptic. might need a follow up PR to clean up.

Originally posted by @jimexist in #1945 (review)
@doki23 doki23 changed the title follow up PR cleaning up statements.remove(0) [follow up]cleaning up statements.remove(0) Mar 11, 2022
@doki23 doki23 mentioned this issue Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

return VecDeque for DFParser::parse_sql
1 participant
@doki23