Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DistinctCount support #384

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Add DistinctCount support #384

merged 2 commits into from
Oct 19, 2022

Conversation

r4ntix
Copy link
Contributor

@r4ntix r4ntix commented Oct 18, 2022

Which issue does this PR close?

Closes #5

Rationale for this change

See #5

What changes are included in this PR?

  • Add distinct field for PhysicalAggregateExprNode in ballista.proto file
  • Add DistinctCount support in to_proto.rs file

Are there any user-facing changes?

None

@andygrove
Copy link
Member

Thanks @r4ntix. This looks good, but could you add a roundtrip test in mod roundtrip_tests?

@r4ntix
Copy link
Contributor Author

r4ntix commented Oct 18, 2022

Thanks @r4ntix. This looks good, but could you add a roundtrip test in mod roundtrip_tests?

Thanks feedback, I will add test for this :)

@r4ntix
Copy link
Contributor Author

r4ntix commented Oct 19, 2022

@andygrove I add a roundtrip_distinct_count test. Could you please review?

@Dandandan Dandandan merged commit 610db7a into apache:master Oct 19, 2022
@Dandandan
Copy link
Contributor

Thank you @r4ntix

@yahoNanJing yahoNanJing mentioned this pull request Oct 20, 2022
Closed
@r4ntix r4ntix deleted the issues-5 branch March 18, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dandandan Dandandan Dandandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ballista assumes all aggregate expressions are not DISTINCT
3 participants
@r4ntix @andygrove @Dandandan