Fix documentation example #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s now. Change the old CSV code to use the Parquet code, and provide also the SQL query together with the expected output
andygrove
approved these changes
Sep 28, 2022
|
@onthebridgetonowhere It looks like you need to run |
Sorry about that, it should be fixed now (at least on my machine it does not complain anymore). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
There is no issue related to this PR
Rationale for this change
Outdated or wrong documentation. Given that these are the main examples linked from the main README.md, I think it's worth fixing them.
What changes are included in this PR?
One code snippet for the distributed SQL example is wrong (likely a copy paste error), and the other example uses the New York Taxi and Limousine Commission data, which are now only provided as Parquet files. Thus, this PR updates the example to use Parquet instead.
Are there any user-facing changes?
No