Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): make Arrow version selection more flexible #2525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felipecrv
Copy link
Contributor

@felipecrv felipecrv commented Feb 14, 2025

The driver manager doesn't have to necessarily require the same version that the datafusion driver requires (due to datafusion's specific arrow version requirements).

Fixes #2524

@felipecrv felipecrv requested a review from wjones127 as a code owner February 14, 2025 20:03
@github-actions github-actions bot modified the milestone: ADBC Libraries 17 Feb 14, 2025
@felipecrv felipecrv changed the title rust: make Arrow version selection more flexible chore(rust): make Arrow version selection more flexible Feb 14, 2025
@lidavidm
Copy link
Member

Hmm, should we set up CI to make sure things (minus Datafusion) build with a few versions of the Rust Arrow crate?

@mbrobbel
Copy link
Contributor

Testing this in CI won't work when the datafusion driver is in the workspace (because it locks the arrow version in the workspace).

@felipecrv
Copy link
Contributor Author

Testing this in CI won't work when the datafusion driver is in the workspace (because it locks the arrow version in the workspace).

That's what I suspected. It's a tricky issue. We could discuss on the issue page the best way to decouple adbc_core from driver/datafusion.

@mbrobbel
Copy link
Contributor

Testing this in CI won't work when the datafusion driver is in the workspace (because it locks the arrow version in the workspace).

That's what I suspected. It's a tricky issue. We could discuss on the issue page the best way to decouple adbc_core from driver/datafusion.

We could maybe move the datafusion driver to the datafusion repo or use two workspaces in this repo (one with the core crate and the other with the drivers)?

@felipecrv
Copy link
Contributor Author

The 2-workspace solution sounds good. Moving to datafusion sounds even better.

Does Rust tooling assume one-repo==one-workspace anywhere?

@mbrobbel
Copy link
Contributor

Moving to datafusion sounds even better.

+1

Does Rust tooling assume one-repo==one-workspace anywhere?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust: more flexible Arrow version requirements
3 participants