Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always inject disable field into plugin schema #3272

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

spacewander
Copy link
Member

Fix apache/apisix-dashboard#1227

Signed-off-by: spacewander [email protected]

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander spacewander marked this pull request as ready for review January 13, 2021 12:03
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me 🤔

Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed

Signed-off-by: spacewander <[email protected]>
@spacewander
Copy link
Member Author

@membphis
CI pass.

@juzhiyuan
Copy link
Member

ping @membphis

@membphis membphis merged commit 1a1fe09 into apache:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The API for fetching all plugins should return disable property
4 participants