Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request help: Health Checks can support customized PORT ? #1811

Closed
souzens opened this issue Jul 7, 2020 · 3 comments · Fixed by #1914
Closed

request help: Health Checks can support customized PORT ? #1811

souzens opened this issue Jul 7, 2020 · 3 comments · Fixed by #1914
Assignees
Labels
enhancement New feature or request

Comments

@souzens
Copy link

souzens commented Jul 7, 2020

sometimes http work and health check listen on different ports ,

like spring boot cloud
http api request works on 8080,
but actuator health works on 8888 port

so a router config like :

            "active": {
                "http_path": "/actuator/health",
                "port": "8888",
                "host": "test",
                "healthy": {
                    "interval": 2,
                    "successes": 1
                },
                "unhealthy": {
                    "interval": 1,
                    "http_failures": 2
                }
            },
            "passive": {
                "healthy": {
                    "http_statuses": [200],
                    "successes": 3
                },
                "unhealthy": {
                    "http_statuses": [503,404],
                    "http_failures": 3,
                    "tcp_failures": 3
                }
            }

i did not find any health port define in https://github.com/apache/incubator-apisix/blob/master/apisix/schema_def.lua#L81

is it supported now ?

Originally posted by @souzens in #1809 (comment)

@membphis
Copy link
Member

membphis commented Jul 7, 2020

yes, we can support this feature. it seems useful.

@membphis membphis added the enhancement New feature or request label Jul 7, 2020
@membphis
Copy link
Member

membphis commented Jul 7, 2020

welcome PR

@shuaijinchao
Copy link
Member

I will deal with this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants