Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: benchmark scripts and apisix command OSX compatibility for development #1649

Closed
qiukeren opened this issue Jun 4, 2020 · 0 comments · Fixed by #1650
Closed

bug: benchmark scripts and apisix command OSX compatibility for development #1649

qiukeren opened this issue Jun 4, 2020 · 0 comments · Fixed by #1650

Comments

@qiukeren
Copy link
Contributor

qiukeren commented Jun 4, 2020

Issue description

Here are two uncompatible on OSX:

  1. run.sh,sed sed -i "s/worker_processes .*/worker_processes $worker_cnt;/g" conf/nginx.confdoes not work on mac, it should be replaced with sed -i "" "s/worker_processes .*/worker_processes $worker_cnt;/g" conf/nginx.conf on MAC.
  2. apisix when reload, os.execute return 3 values while linux return only 1.

what's more, I suggest change worker_processes \d+ to worker_processes .* in run.sh, because nginx.conf is usually set to worker_process = auto.

Environment

  • apisix version (cmd: apisix version): 1.3
  • OS: OSX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant