bug: ./utils/install-dependencies.sh use a wrong link about linux-install-luarocks.sh

[zll600]

Current Behavior

the script ./utils/install-dependencies.sh on tag 3.7.0 will use linux-install-luarocks.sh which is on master.

apisix/utils/install-dependencies.sh

Line 115 in ec77fb8

curl https://raw.githubusercontent.com/apache/apisix/master/utils/linux-install-luarocks.sh -sL | bash -

Expected Behavior

the script ./utils/install-dependencies.sh on tag 3.7.0 should use linux-install-luarocks.sh which is on tag 3.7.0.

Error Logs

No response

Steps to Reproduce

1. ./utils/install-dependencies.sh (on tag 3.7.0)

Environment

• APISIX version (run apisix version):
• Operating system (run uname -a):
• OpenResty / Nginx version (run openresty -V or nginx -V):
• etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
• APISIX Dashboard version, if relevant:
• Plugin runner version, for issues related to plugin runners:
• LuaRocks version, for installation issues (run luarocks --version):

[sheharyaar]

Hi @zll600 , thank you for reporting, would you be interested to create a PR ?

[Vacant2333]

the master branch already update this

apisix/utils/install-dependencies.sh

Line 139 in 1a34a29

./utils/linux-install-luarocks.sh

[zll600]

maybe also need to update here:

apisix/autodocs/generate.sh

Line 27 in 1a34a29

curl https://raw.githubusercontent.com/apache/apisix/master/utils/linux-install-luarocks.sh -sL | bash -

[zll600]

the master branch already update this

apisix/utils/install-dependencies.sh

Line 139 in 1a34a29

./utils/linux-install-luarocks.sh

what should we do with the existing release branch? such as release/3.7
https://github.com/apache/apisix/blob/release/3.7/utils/install-dependencies.sh#L114

[Vacant2333]

@AlinsRan could u help him confirm this?

[AlinsRan]

what should we do with the existing release branch? such as release/3.7 https://github.com/apache/apisix/blob/release/3.7/utils/install-dependencies.sh#L114

We can update in the history branch, such as release/3.7.
Would you be interested to create a PR.

[Vacant2333]

i can help this, pls assign to me @AlinsRan

[AlinsRan]

If we want to ensure that the historical version can be installed normally, we need to keep the old script and use the new script in the new version. This way, there is no need to update all historical branches.

[zll600]

@AlinsRan Sorry. The historical version refer the file which on master branch which should be the latest version.
So I do not understand here.

we need to keep the old script and use the new script in the new version.

Can you explain more? Thank you.

[AlinsRan]

@zll600
What I mean is that historical versions still use scripts from the master branch for installation. For example, 3.3 3.4, this can cause the source code installation to fail.
There are two solutions to solve this problem:

• Update documents and scripts in all historical versions.
• The script of the master branch is compatible with historical versions

[Vacant2333]

@zll600 What I mean is that historical versions still use scripts from the master branch for installation. For example, 3.3 3.4, this can cause the source code installation to fail. There are two solutions to solve this problem:

• Update documents and scripts in all historical versions.
• The script of the master branch is compatible with historical versions

Ok, i got it, we have update the priority to High now

[Vacant2333]

hello, everyone, i may have no time to update this issue, did anyone want to fix this docs?

[smileby]

The following two lines of code in the historical branch need to be updated. The branch information is release_2.13 ~ 3.8

apisix/utils/install-dependencies.sh

Line 144 in 1a34a29

curl https://raw.githubusercontent.com/apache/apisix/master/utils/linux-install-luarocks.sh -sL | bash -

apisix/autodocs/generate.sh

Line 27 in 1a34a29

curl https://raw.githubusercontent.com/apache/apisix/master/utils/linux-install-luarocks.sh -sL | bash -

@Vacant2333 @AlinsRan @zll600 Can you help me confirm that the furthest branch is 2.13? I checked and there is no corresponding code before 2.13.

[zll600]

@smileby I found the script was add in v2.11.0 by this pr: #5209

[smileby]

Then I should make modifications to the 2.11.0~3.8.0 version branches. What does everyone think of this?

[zll600]

@zll600 What I mean is that historical versions still use scripts from the master branch for installation. For example, 3.3 3.4, this can cause the source code installation to fail. There are two solutions to solve this problem:

• Update documents and scripts in all historical versions.
• The script of the master branch is compatible with historical versions

we can update the script of master to be compatible with histroical versions. I think this may be easier.

[smileby]

@zll600 What I mean is that historical versions still use scripts from the master branch for installation. For example, 3.3 3.4, this can cause the source code installation to fail. There are two solutions to solve this problem:

• Update documents and scripts in all historical versions.
• The script of the master branch is compatible with historical versions

we can update the script of master to be compatible with histroical versions. I think this may be easier.

I don't think it's good practice to constantly be compatible with older versions, let's see if anyone else has any better ideas

[smileby]

@zll600 What I mean is that historical versions still use scripts from the master branch for installation. For example, 3.3 3.4, this can cause the source code installation to fail. There are two solutions to solve this problem:

• Update documents and scripts in all historical versions.
• The script of the master branch is compatible with historical versions

we can update the script of master to be compatible with histroical versions. I think this may be easier.

I don't think it's good practice to constantly be compatible with older versions, let's see if anyone else has any better ideas

@AlinsRan @spacewander @pottekkat @kayx23 any better ideas

[spacewander]

we can update the script of master to be compatible with histroical versions. I think this may be easier.

Vote for this.

[smileby]

My question is, where do they get their version numbers from and how can they be compatible with older versions?