Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove route name length limit #2759

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

Baoyuantop
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #2610

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@Baoyuantop Baoyuantop requested review from nic-chen and bzp2010 March 6, 2023 05:47
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #2759 (6c158db) into master (7c264b0) will decrease coverage by 5.52%.
The diff coverage is n/a.

❗ Current head 6c158db differs from pull request most recent head 5778ce3. Consider uploading reports for the commit 5778ce3 to get more accurate results

@@            Coverage Diff             @@
##           master    #2759      +/-   ##
==========================================
- Coverage   76.42%   70.91%   -5.52%     
==========================================
  Files         139      198      +59     
  Lines        3759     7757    +3998     
  Branches      877      873       -4     
==========================================
+ Hits         2873     5501    +2628     
- Misses        886     1953    +1067     
- Partials        0      303     +303     
Flag Coverage Δ
backend-e2e-test-ginkgo 65.40% <ø> (?)
backend-unit-test 50.11% <ø> (?)
frontend-e2e-test 69.34% <ø> (-7.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/entity/entity.go 90.90% <ø> (ø)
...nents/PluginFlow/components/FlowGraph/FlowGraph.ts 1.36% <0.00%> (-82.20%) ⬇️
web/src/components/PluginFlow/PluginFlow.tsx 1.42% <0.00%> (-80.00%) ⬇️
web/src/components/PluginFlow/constants.ts 29.03% <0.00%> (-58.07%) ⬇️
...components/PluginFlow/components/Toolbar/index.tsx 2.40% <0.00%> (-27.72%) ⬇️
web/src/pages/Route/components/Step3/index.tsx 53.12% <0.00%> (-9.38%) ⬇️
...pages/Route/components/CreateStep4/CreateStep4.tsx 90.90% <0.00%> (-9.10%) ⬇️
web/src/helpers.tsx 70.49% <0.00%> (-6.56%) ⬇️
web/src/components/Plugin/UI/api-breaker.tsx 69.23% <0.00%> (-5.13%) ⬇️
web/src/pages/Route/Create.tsx 81.88% <0.00%> (-3.94%) ⬇️
... and 68 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nic-chen
Copy link
Member

nic-chen commented Mar 6, 2023

better to add a test cases to make sure it works.

@Baoyuantop Baoyuantop merged commit a393073 into apache:master Mar 7, 2023
@Baoyuantop Baoyuantop deleted the fix-max-limit branch March 7, 2023 08:05
guoqqqi pushed a commit to guoqqqi/apisix-dashboard that referenced this pull request Mar 8, 2023
Baoyuantop added a commit to Baoyuantop/apisix-dashboard that referenced this pull request Mar 22, 2023
Baoyuantop added a commit that referenced this pull request Mar 23, 2023
* chore: update the year in the  NOTICE (#2726)

fix: #2724

* fix plugins display in list of routes (#2704)

Co-authored-by: litesun <[email protected]>

* fix: plugin config page error (#2739)

* fix: plugin disable invalid in API /plugin?all=true (#2737)

* chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /web (#2730)

* fix: update URL of the online playground (#2760)

* chore: update dependency (#2752)

* chore: update dependency

---------

Co-authored-by: rongxin <[email protected]>

* fix: remove route name length limit (#2759)

* fix: change regex template to optional in proxy write (#2762)

* fix: ssl table expiration time display (#2763)

* feat: add search functionality for id, host, and description fields (#2750)

Co-authored-by: Anil Durmus <[email protected]>

* fix: disable global plugin invalid (#2757)

* feat: support ipv6 in upstream nodes (#2766)

* fix: upstream nodes metadata miss (#2773)

* fix: remove ssl check in redirect https (#2770)

---------

Co-authored-by: Shivam0500 <[email protected]>
Co-authored-by: incubator4 <[email protected]>
Co-authored-by: litesun <[email protected]>
Co-authored-by: Joanthan Chen <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: JunXu Chen <[email protected]>
Co-authored-by: Xin Rong <[email protected]>
Co-authored-by: rongxin <[email protected]>
Co-authored-by: Anil Baki Durmus <[email protected]>
Co-authored-by: Anil Durmus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route name max length has different values in schema.json and /api/internal/core/entity/entity.go file
4 participants