-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search functionality for ID, host, and description fields #2750
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2750 +/- ##
==========================================
- Coverage 76.42% 74.15% -2.28%
==========================================
Files 139 201 +62
Lines 3759 7859 +4100
Branches 877 881 +4
==========================================
+ Hits 2873 5828 +2955
- Misses 886 1721 +835
- Partials 0 310 +310
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Codes LGTM!
You will also need to provide E2E testing for this code, so feel free to ask questions if you have any.
@Baoyuantop could you review it again? I implement the e2e testings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤔
Nice job, thanks for your contribution! |
…pache#2750) Co-authored-by: Anil Durmus <[email protected]>
* chore: update the year in the NOTICE (#2726) fix: #2724 * fix plugins display in list of routes (#2704) Co-authored-by: litesun <[email protected]> * fix: plugin config page error (#2739) * fix: plugin disable invalid in API /plugin?all=true (#2737) * chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /web (#2730) * fix: update URL of the online playground (#2760) * chore: update dependency (#2752) * chore: update dependency --------- Co-authored-by: rongxin <[email protected]> * fix: remove route name length limit (#2759) * fix: change regex template to optional in proxy write (#2762) * fix: ssl table expiration time display (#2763) * feat: add search functionality for id, host, and description fields (#2750) Co-authored-by: Anil Durmus <[email protected]> * fix: disable global plugin invalid (#2757) * feat: support ipv6 in upstream nodes (#2766) * fix: upstream nodes metadata miss (#2773) * fix: remove ssl check in redirect https (#2770) --------- Co-authored-by: Shivam0500 <[email protected]> Co-authored-by: incubator4 <[email protected]> Co-authored-by: litesun <[email protected]> Co-authored-by: Joanthan Chen <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JunXu Chen <[email protected]> Co-authored-by: Xin Rong <[email protected]> Co-authored-by: rongxin <[email protected]> Co-authored-by: Anil Baki Durmus <[email protected]> Co-authored-by: Anil Durmus <[email protected]>
…pache#2750) Co-authored-by: Anil Durmus <[email protected]>
Why submit this pull request?
What changes will this PR take into?
This PR adds search functionality for fields like ID, host, and description. Users can now search for specific entries in the dataset using keywords in these fields.
Related issues
fix/resolve #2729
Checklist: