-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport v2.4 changelog and version #1489
Backport v2.4 changelog and version #1489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
==========================================
- Coverage 68.43% 59.90% -8.53%
==========================================
Files 48 48
Lines 3038 3038
==========================================
- Hits 2079 1820 -259
- Misses 720 977 +257
- Partials 239 241 +2
Continue to review full report at Codecov.
|
@liuxiran Good catch, thank you so much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -24,7 +24,7 @@ | |||
## Install from RPM | |||
|
|||
```sh | |||
$ sudo yum install -y https://github.com/apache/apisix-dashboard/releases/download/v2.3/apisix-dashboard-v2.3-1.x86_64.rpm | |||
$ sudo yum install -y https://github.com/apache/apisix-dashboard/releases/download/v2.4/apisix-dashboard-v2.4-1.x86_64.rpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liuxiran Hi, this link is broken, please take a look.
Please answer these questions before submitting a pull request
Backport patches
when I ran manager-api locally, I found that the
Version
is still2.3
, the reason is that we forgot to backport the changlog and version from branch v2.4 to master.Source branch
v2.4
Related commits and pull requests
pr: feat: bump to version v2.4 #1460 fix: fix typo of CHANGELOG.md #1462 fix: fix typo of CHANGELOG.md #1463
commit: 148b4ea (the version in
README.md
has already modified by docs: update Release info & Makefile tip #1478, so this commit does not need to backport )Target branch
master