Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport v2.4 changelog and version #1489

Merged
merged 3 commits into from
Feb 20, 2021

Conversation

liuxiran
Copy link
Contributor

@liuxiran liuxiran commented Feb 20, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

Backport patches

  • Why need to backport?
    image

when I ran manager-api locally, I found that the Version is still 2.3, the reason is that we forgot to backport the changlog and version from branch v2.4 to master.

@codecov-io
Copy link

codecov-io commented Feb 20, 2021

Codecov Report

Merging #1489 (714288a) into master (65f792a) will decrease coverage by 8.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
- Coverage   68.43%   59.90%   -8.53%     
==========================================
  Files          48       48              
  Lines        3038     3038              
==========================================
- Hits         2079     1820     -259     
- Misses        720      977     +257     
- Partials      239      241       +2     
Impacted Files Coverage Δ
api/internal/core/entity/entity.go 18.75% <0.00%> (-81.25%) ⬇️
...l/handler/route_online_debug/route_online_debug.go 7.14% <0.00%> (-66.67%) ⬇️
api/internal/handler/data_loader/route_import.go 30.24% <0.00%> (-34.68%) ⬇️
api/internal/utils/consts/api_error.go 25.00% <0.00%> (-25.00%) ⬇️
api/internal/core/store/storehub.go 45.91% <0.00%> (-24.49%) ⬇️
api/internal/utils/json_patch.go 34.48% <0.00%> (-24.14%) ⬇️
api/internal/filter/schema.go 31.93% <0.00%> (-23.53%) ⬇️
api/internal/log/log.go 30.00% <0.00%> (-20.00%) ⬇️
api/internal/handler/global_rule/global_rule.go 66.12% <0.00%> (-17.75%) ⬇️
api/internal/utils/utils.go 52.94% <0.00%> (-12.95%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f792a...714288a. Read the comment docs.

@imjoey
Copy link
Member

imjoey commented Feb 20, 2021

@liuxiran Good catch, thank you so much.

Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@juzhiyuan juzhiyuan merged commit b40cb40 into apache:master Feb 20, 2021
@@ -24,7 +24,7 @@
## Install from RPM

```sh
$ sudo yum install -y https://github.com/apache/apisix-dashboard/releases/download/v2.3/apisix-dashboard-v2.3-1.x86_64.rpm
$ sudo yum install -y https://github.com/apache/apisix-dashboard/releases/download/v2.4/apisix-dashboard-v2.4-1.x86_64.rpm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuxiran Hi, this link is broken, please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants