Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only enable cors plugin will take empty object #996

Closed
souzens opened this issue Dec 9, 2020 · 2 comments
Closed

only enable cors plugin will take empty object #996

souzens opened this issue Dec 9, 2020 · 2 comments
Labels
duplicate This issue or pull request already exists plugin

Comments

@souzens
Copy link

souzens commented Dec 9, 2020

Bug report

Describe the bug

in plugin step , if I only enable cors plugin but not to click on SETTINGS button and click on ”确认"

Finally, it seems the data of cors object is empty by reading etcd.

My idea is that there should be a default value when only the plugin is enabled

image

System information

  • OS: [e.g. macOS, Windows] centos
  • Browser (if applies) [e.g. Chrome, Safari, Edge] Chrome
  • Version: [e.g. 2.0-rc3] 2.0-2.11
@souzens souzens added the bug Something isn't working label Dec 9, 2020
@juzhiyuan juzhiyuan added duplicate This issue or pull request already exists plugin labels Dec 9, 2020
@juzhiyuan
Copy link
Member

will be resolved with #898

@juzhiyuan juzhiyuan removed the bug Something isn't working label Dec 9, 2020
@juzhiyuan
Copy link
Member

doc https://github.com/apache/apisix/blob/master/doc/plugins/cors.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juzhiyuan @souzens