Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discuss: how to get different type of plugin schema in 2.0 manager-api #605

Closed
1 of 5 tasks
liuxiran opened this issue Oct 27, 2020 · 13 comments · Fixed by #1111
Closed
1 of 5 tasks

discuss: how to get different type of plugin schema in 2.0 manager-api #605

liuxiran opened this issue Oct 27, 2020 · 13 comments · Fixed by #1111
Assignees
Labels
backend discuss wait for update 1. Solution 2. Due date 3. Assignees if needed
Milestone

Comments

@liuxiran
Copy link
Contributor

liuxiran commented Oct 27, 2020

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirements
  • Feature or performance improvement
  • Other

Premise

Refered to apache/apisix#2441 (comment), we are tring to implement the feature, that getting different plugin schema by schema type through query params.

After refactoring, manager-api will get the plugin schema via schema.json, which is generated by schema-sync.sh and schema-sync.lua instead of getting directly from admin-api

Question

Is it possible to add this query param in 2.0 manager-api?

  • change the plugin schema generated by schema-sync.sh and schema-sync.lua ?

  • some other way?

@liuxiran
Copy link
Contributor Author

cc @juzhiyuan @nic-chen @ShiningRush

@juzhiyuan juzhiyuan assigned liuxiran and nic-chen and unassigned liuxiran Oct 27, 2020
@juzhiyuan juzhiyuan added this to the 2.0 milestone Oct 27, 2020
@nic-chen
Copy link
Member

@liuxiran

I think we need to update two files:

  1. update schema-sync.lua so that it can sync all types schemas.

  2. update internal/handler/plugin/plugin.go so that it can get different plugin schema by type through query params

@nic-chen
Copy link
Member

we could do this after the feature you mentioned is done.

@nic-chen nic-chen modified the milestones: 2.0, 2.1 Oct 27, 2020
@liuxiran
Copy link
Contributor Author

@liuxiran

I think we need to update two files:

1. update `schema-sync.lua` so that it can sync all types schemas.

2. update `internal/handler/plugin/plugin.go` so that it can get different plugin schema by type through query params

Thx for your feedback @nic-chen :), when the feature done, I`ll update the comment.

@moonming
Copy link
Member

moonming commented Nov 3, 2020

@liuxiran @nic-chen
I have been busy during this period and I did not see this issue. Welcome to post this kind of important discussion to the mailing list.
Going back to the problem of synchronization schema, what I hope to achieve in the end is:

  1. The tool for synchronizing schema has nothing to do with the dashboard project. After all, this is a product that the data plane should generate;
  2. When the schema of the data plane changes, there is no need to modify the code of this tool;
  3. The dashboard project should not depend on Lua.

What do you think?

@membphis
Copy link
Member

membphis commented Nov 3, 2020

@moonming
Copy link
Member

@nic-chen will you lead this feature? We have reached a consensus on the mailing list

@nic-chen
Copy link
Member

@nic-chen will you lead this feature? We have reached a consensus on the mailing list

yes, of course.

@membphis
Copy link
Member

membphis commented Nov 17, 2020

@nic-chen do we will implement this feature in milestone 2.2?

@nic-chen
Copy link
Member

@nic-chen do we will implement this feature in milestone 2.2?

sure

@membphis membphis modified the milestones: 2.1, 2.2, 2.3, 2.1.1 Nov 18, 2020
@membphis
Copy link
Member

related issue: apache/apisix#2700

@nic-chen
Copy link
Member

@membphis
I think we could move it to 2.2
what do you think?

@membphis membphis modified the milestones: 2.1.1, 2.2 Nov 30, 2020
@membphis
Copy link
Member

@membphis
I think we could move it to 2.2
what do you think?

agree, and set the milestone to 2.2

@membphis membphis removed this from the 2.2 milestone Dec 7, 2020
@membphis membphis added this to the 2.3 milestone Dec 7, 2020
@nic-chen nic-chen added the wait for update 1. Solution 2. Due date 3. Assignees if needed label Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend discuss wait for update 1. Solution 2. Due date 3. Assignees if needed
Projects
None yet
5 participants