Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When creating a route, the domain name is v1_test-api.xxx.com and it cannot pass the verification json schema verification #1167

Closed
json7 opened this issue Dec 30, 2020 · 6 comments · Fixed by #1177
Closed

When creating a route, the domain name is v1_test-api.xxx.com and it cannot pass the verification json schema verification #1167

json7 opened this issue Dec 30, 2020 · 6 comments · Fixed by #1177
Labels
backend bug Something isn't working
Milestone
2.3

Comments

@json7
Copy link

json7 commented Dec 30, 2020

Bug report

Describe the bug

A clear and concise description of what the bug is.

How to Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

Add screenshots to help explain your problem if applicable.

System information

  • OS: [e.g. macOS, Windows]
  • Browser (if applies) [e.g. Chrome, Safari, Edge]
  • Version: [e.g. 2.0-rc3]

Additional context

Add any other context about the problem here.
@json7 json7 added the bug Something isn't working label Dec 30, 2020
@juzhiyuan
Copy link
Member

cc @idbeta

@juzhiyuan
Copy link
Member

juzhiyuan commented Dec 31, 2020 •
edited
Loading

I just checked this host is forbidden by ManagerAPI, let's @nic-chen @starsz take a look.

{"code":10000,"message":"schema validate failed: hosts.0: Does not match pattern '^\\*?[0-9a-zA-Z-.]+$'"}

image

@juzhiyuan juzhiyuan added backend discuss bug Something isn't working and removed bug Something isn't working checking labels Dec 31, 2020
@nic-chen
Copy link
Member

We don't support _ in host or hosts now.

Top-level domains do not support _.

But some domain name registrars seem to support _ for subdomains.

Do we need to support it ?

cc @membphis @spacewander

spacewander added a commit to spacewander/incubator-apisix that referenced this issue Dec 31, 2020
@spacewander
feat: allow host with underscore
940956f 
Fix apache/apisix-dashboard#1167
Signed-off-by: spacewander <[email protected]>
@spacewander spacewander mentioned this issue Dec 31, 2020
Merged
4 tasks
@spacewander
Copy link
Member

Sure.

spacewander added a commit to spacewander/incubator-apisix that referenced this issue Dec 31, 2020
@spacewander
feat: allow host with underscore
b746b0c 
Fix apache/apisix-dashboard#1167
Signed-off-by: spacewander <[email protected]>
@membphis
Copy link
Member

membphis commented Dec 31, 2020 •
edited
Loading

@nic-chen we need to sync the latest JSON schema from APISIX

related PR merged: apache/apisix#3165

@juzhiyuan juzhiyuan removed the discuss label Dec 31, 2020
@nic-chen
Copy link
Member

@nic-chen we need to sync the latest JSON schema from APISIX

related PR merged: apache/apisix#3165

OK

@nic-chen nic-chen mentioned this issue Dec 31, 2020
Merged
3 tasks
@juzhiyuan juzhiyuan added this to the 2.3 milestone Jan 4, 2021
@moonming moonming changed the title 创建路由 的时候 ,域名 为 v1_test-api.xxx.com 无法通过验证 json schema验证 When creating a route, the domain name is v1_test-api.xxx.com and it cannot pass the verification json schema verification Jan 4, 2021
@nic-chen nic-chen closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend bug Something isn't working
Projects
None yet
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

chore: sync json schema from Apache APISIX 2.2 nic-chen/incubator-apisix-dashboard
5 participants
@juzhiyuan @json7 @spacewander @membphis @nic-chen