address review comments

Author: villebro

plugins/plugin-chart-echarts/src/Pie/EchartsPie.tsx

@@ -20,6 +20,6 @@ import React from 'react';
 import { EchartsPieProps } from './types';
 import Echart from '../components/Echart';
 
-export default function EchartsPie(props: EchartsPieProps) {
-  return <Echart height={props.height} width={props.width} echartOptions={props.echartOptions} />;
+export default function EchartsPie({ height, width, echartOptions }: EchartsPieProps) {
+  return <Echart height={height} width={width} echartOptions={echartOptions} />;
 }

plugins/plugin-chart-echarts/src/Pie/buildQuery.ts

@@ -19,9 +19,5 @@
 import { buildQueryContext, QueryFormData } from '@superset-ui/query';
 
 export default function buildQuery(formData: QueryFormData) {
-  return buildQueryContext(formData, baseQueryObject => [
-    {
-      ...baseQueryObject,
-    },
-  ]);
+  return buildQueryContext(formData);
 }

plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx

@@ -20,6 +20,10 @@ import React from 'react';
 import { EchartsTimeseriesProps } from './types';
 import Echart from '../components/Echart';
 
-export default function EchartsTimeseries(props: EchartsTimeseriesProps) {
-  return <Echart height={props.height} width={props.width} echartOptions={props.echartOptions} />;
+export default function EchartsTimeseries({
+  height,
+  width,
+  echartOptions,
+}: EchartsTimeseriesProps) {
+  return <Echart height={height} width={width} echartOptions={echartOptions} />;
 }

plugins/plugin-chart-echarts/src/Timeseries/buildQuery.ts

@@ -49,15 +49,9 @@ export default function buildQuery(formData: QueryFormData) {
               index: ['__timestamp'],
               columns: formData.groupby,
               // Create 'dummy' sum aggregates to assign cell values in pivot table
-              aggregates: baseQueryMetrics
-                .map(metric => metric.label)
-                .reduce(
-                  (obj, cur) => ({
-                    ...obj,
-                    [cur]: { operator: 'sum' },
-                  }),
-                  {},
-                ),
+              aggregates: Object.fromEntries(
+                baseQueryMetrics.map(metric => [metric.label, { operator: 'sum' }]),
+              ),
             },
           },
           formData.contributionMode