From d5ccb038f69193fb63b5169d7adc5da19859c9d8 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Wed, 8 Sep 2021 12:29:33 -0700 Subject: [PATCH] Set $TMPDIR as well as java.io.tmpdir. This helps functions like tmpnam() and tmpfile() to "just work", like their Java equivalents. Bug: https://issuetracker.google.com/36991167 Bug: http://b/174682340 Test: atest FrameworksCoreTests:android.app.activity.ActivityThreadTest Change-Id: Ife785f0ca69a34ba2c6b5d1e8e23f8b883d8fc8f --- core/java/android/app/ActivityThread.java | 8 +++++++- .../src/android/app/activity/ActivityThreadTest.java | 5 +++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/core/java/android/app/ActivityThread.java b/core/java/android/app/ActivityThread.java index 41170a4c27497..749e8f548fabe 100644 --- a/core/java/android/app/ActivityThread.java +++ b/core/java/android/app/ActivityThread.java @@ -6299,7 +6299,13 @@ private void setupGraphicsSupport(Context context) { final File cacheDir = context.getCacheDir(); if (cacheDir != null) { // Provide a usable directory for temporary files - System.setProperty("java.io.tmpdir", cacheDir.getAbsolutePath()); + String tmpdir = cacheDir.getAbsolutePath(); + System.setProperty("java.io.tmpdir", tmpdir); + try { + android.system.Os.setenv("TMPDIR", tmpdir, true); + } catch (ErrnoException ex) { + Log.w(TAG, "Unable to initialize $TMPDIR", ex); + } } else { Log.v(TAG, "Unable to initialize \"java.io.tmpdir\" property " + "due to missing cache directory"); diff --git a/core/tests/coretests/src/android/app/activity/ActivityThreadTest.java b/core/tests/coretests/src/android/app/activity/ActivityThreadTest.java index 000e870369dbf..2d63351b83037 100644 --- a/core/tests/coretests/src/android/app/activity/ActivityThreadTest.java +++ b/core/tests/coretests/src/android/app/activity/ActivityThreadTest.java @@ -87,6 +87,11 @@ public class ActivityThreadTest { new ActivityTestRule<>(TestActivity.class, true /* initialTouchMode */, false /* launchActivity */); + @Test + public void testTemporaryDirectory() throws Exception { + assertEquals(System.getProperty("java.io.tmpdir"), System.getenv("TMPDIR")); + } + @Test public void testDoubleRelaunch() throws Exception { final Activity activity = mActivityTestRule.launchActivity(new Intent());