Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vietnamese translation #744

Merged
merged 2 commits into from
Dec 31, 2020
Merged

Update Vietnamese translation #744

merged 2 commits into from
Dec 31, 2020

Conversation

mwolfinspace
Copy link
Contributor

Add some new translation lines.

@mwolfinspace
Updated Vietnamese translation
58d3d37 
Add some new translation lines.
aonez
aonez requested changes Dec 31, 2020
View reviewed changes
Copy link
Owner

@aonez aonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @1234hdpa! I think some strings have broken characters. Can you check?

Translations/vi.lproj/FinderExtensionLocalizable.strings Outdated
Comment on lines 1 to 7
"Open with Keka" = "M? v?i Keka";
"Compress here" = "N?n t?i ??y";
"Compress to..." = "N?n ??n...";
"Extract here" = "Gi?i n?n t?i ??y";
"Extract to..." = "Gi?i n?n ??n...";
"Extract to \"%@\"" = "Gi?i n?n ??n \"%@\"";
"Compress with Keka" = "N?n v?i Keka";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those rendered bad?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'll check it back. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just replaced these broken words via Xcode. Visual Studio Code doesn't work well as saving these.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used Visual Studio in Mac but probably the encoding for that file was not properly set. Thanks for the fix!

@aonez aonez self-assigned this Dec 31, 2020
@aonez aonez added this to the 1.2.7 milestone Dec 31, 2020
@mwolfinspace
Update some texts
5e1e2e7 
Replace some broken texts in FinderExtensionLocalizable.string
@aonez aonez merged commit c840b72 into aonez:master Dec 31, 2020
@aonez
Copy link
Owner

aonez commented Dec 31, 2020

Web updated already 😊 maybe you want to translate this line too:

Keka/Translations/Web/lang_vi.php

Line 29 in c840b72

$content_download_helper = "Helper";

aonez added a commit that referenced this pull request Jan 7, 2021
@aonez
Added Vietnamese translation to the credits
941036f 
#744
@1234hdpa
@aonez
Copy link
Owner

aonez commented Jan 7, 2021

@1234hdpa just realized the Vietnamese translation is not found in the credits! Just went ahead and added you. Change your name/link if you want 😊

Keka/Translations/Common/Translators.html

Lines 160 to 164 in 941036f

<!-- Vietnamese -->
<span>
<h2>Tiếng Việt</h2>
<span>1234hdpa<a href="https://github.com/1234hdpa">@1234hdpa</a></span>
</span>

@mwolfinspace
Copy link
Contributor Author

Thanks for adding me to the credits!
I'd just added some words for "Helper" and made it easy to understand.

@aonez
Copy link
Owner

aonez commented Jan 7, 2021

I'd just added some words for "Helper" and made it easy to understand.

Where? You'll create a new pull request?

@mwolfinspace
Copy link
Contributor Author

My bad 😅! I forgot it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aonez aonez aonez approved these changes

Assignees

@aonez aonez

Labels
enhancement translation
Projects
None yet
Milestone
1.2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@mwolfinspace @aonez