Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take default roles into consideration in by_role queries #10

Closed
anze3db opened this issue Aug 22, 2021 · 0 comments · Fixed by #78
Closed

Take default roles into consideration in by_role queries #10

anze3db opened this issue Aug 22, 2021 · 0 comments · Fixed by #78

Comments

@anze3db
Copy link
Owner

anze3db commented Aug 22, 2021

Currently, the query for

get_by_role("button")

Only matches elements with the button role explicitly defined, for example: <input role="button">.

The query needs to also take default roles into consideration, so it should also match <button />.

The implementation should follow the rules defined in the W3C spec table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use @testing-library/dom under the hood anze3db/selenium-testing-library
1 participant
@anze3db