-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript paths #10
Comments
I was so happy when I found this, for converting a large existing repo, but then I realized that most of my paths use aliases 😞 |
Happy to accept a PR to fix this! |
I don't think it's an easy fix. I tried hacking my way around it, but it didn't work, and I ran out of time. I'm going to park this for now. |
same issue, hope someone have a good idea. |
@jordaaash Would you accept a PR which adds an ability to specify alias mapping for your two rules? Ideally, it would take the list of aliases from any of these:
|
FYI just to report that I managed to do a rewrite in which the existing import resolution aliases (webpack, jsconfig, tsconfig...) are taken into account. Introducing |
@mbonaci Sorry about that! I had some of my Github emails going to an old work email address for quite a while, so I didn't see the notifications here until yours this week. I'd be happy to accept a PR to fix this behavior, and I'll check out your new package as well. If there's an opportunity for us to consolidate I'm very open to it, as we haven't been updating this in some time. |
@jordaaash No worries.
I'd be open to that. |
When using custom TypeScript paths the import is completely ignored (and therefore ESM invalid):
Correct behaviour:
There is the need to understand if the import path points to a folder or a file and then apply the corresponding logic.
The text was updated successfully, but these errors were encountered: