From bd78d32bb5c77b4f9f50755097b50043d2d2c16b Mon Sep 17 00:00:00 2001 From: kevinheavey Date: Tue, 13 Aug 2024 13:48:11 +0400 Subject: [PATCH] update comment --- ci/order-crates-for-publishing.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ci/order-crates-for-publishing.py b/ci/order-crates-for-publishing.py index 17b4163ab75e68..fd763472934605 100755 --- a/ci/order-crates-for-publishing.py +++ b/ci/order-crates-for-publishing.py @@ -21,8 +21,11 @@ def load_metadata(): return json.loads(subprocess.Popen( cmd, shell=True, stdout=subprocess.PIPE).communicate()[0]) -# Cargo publish if fine with circular dev-dependencies if +# Cargo publish is fine with circular dev-dependencies if # they are path deps. +# However, cargo still fails if deps are path deps with versions +# (this when you use `workspace = true`): https://github.com/rust-lang/cargo/issues/4242 +# This function checks for these good and bad uses of dev dependencies. def is_path_dev_dep(package, dependency, wrong_path_dev_dependencies): no_explicit_version = '*' is_special_cased = False