Skip to content

Commit 815026b

Browse files
committed
Support ECM 7.0.6
1 parent 543f8d6 commit 815026b

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/sage/interfaces/ecm.py

-1
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,6 @@ def _find_factor(self, n, factor_digits, B1, **kwds):
508508
"""
509509
n = self._validate(n)
510510
kwds.setdefault('c', 1000000000)
511-
kwds.setdefault('I', 1)
512511
if factor_digits is not None:
513512
B1 = self.recommended_B1(factor_digits)
514513
kwds['one'] = True

src/sage/libs/libecm.pyx

+6-4
Original file line numberDiff line numberDiff line change
@@ -149,11 +149,13 @@ def ecmfactor(number, double B1, verbose=False, sigma=0):
149149
Some special cases::
150150
151151
sage: ecmfactor(1, 100)
152-
(True, 1, ...)
152+
Traceback (most recent call last):
153+
...
154+
ValueError: Input number (1) must be greater than 1
153155
sage: ecmfactor(0, 100)
154156
Traceback (most recent call last):
155157
...
156-
ValueError: Input number (0) must be positive
158+
ValueError: Input number (0) must be greater than 1
157159
"""
158160
cdef mpz_t n, f
159161
cdef int res
@@ -164,8 +166,8 @@ def ecmfactor(number, double B1, verbose=False, sigma=0):
164166
sage_int_number = Integer(number)
165167
sage_int_sigma = Integer(sigma)
166168

167-
if number <= 0:
168-
raise ValueError("Input number (%s) must be positive"%number)
169+
if number <= 1:
170+
raise ValueError("Input number (%s) must be greater than 1"%number)
169171

170172
if verbose:
171173
print("Performing one curve with B1=%1.0f" % B1)

0 commit comments

Comments
 (0)