Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device memory check will make mistake if browser name parsed from userAgent is not 'Chrome', 'Chromium' or 'Opera'. #14

Open
yyarrow opened this issue Mar 2, 2021 · 0 comments

Comments

@yyarrow
Copy link

yyarrow commented Mar 2, 2021

Device memory check will make mistake if browser name parsed from userAgent is not 'Chrome', 'Chromium' or 'Opera'.
It's because this code:
if (fingerprint.deviceMemory !== 0 && !(BROWSER_REF === BROWSERS.CHROME && BROWSER_VERSION_REF >= 63) && !(/Opera/.test(BROWSER_REF) && BROWSER_VERSION_REF >= 50)) { // If deviceMemory != 0 and not recent Chrome or Opera testResult = INCONSISTENT;
Any other browser will lead to a inconsistent result.
e.g.
when use qq browser,
ua: "userAgent": "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.25 Safari/537.36 Core/1.70.3861.400 QQBrowser/10.7.4313.400"
memory: 8G
but memory check failed:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant