[typescript] Runtime declares CommonToken(source, .....) wrong.

[kaby76]

I need to create a CommonToken for python3 but for TypeScript. Unfortunately, "source" is declared as a number here. That's wrong. Completely blocked.

[ericvergnaud]

Can you try: constructor(source: [ TokenSource, InputStream ], type: number, channel: number, start: number, stop: number); ?
(typically you would get the source from the original token)

[kaby76]

Tried and got a couple different things.

Python3LexerBase.ts:68:38 - error TS1005: ',' expected.

68         return new CommonToken(source: [ this, this.input_ ], type, 0, start, stop);
                                        ~

Python3LexerBase.ts:68:33 - error TS2345: Argument of type '(CharStream | this)[]' is not assignable to parameter of type 'number'.

68         return new CommonToken( [ this, this.input_ ], type, 0, start, stop);
                                   ~~~~~~~~~~~~~~~~~~~~~

[ericvergnaud]

second issue suggests that you haven't updated CommonToken.d.ts ?
(first issue is invalid syntax)

[kaby76]

grammars-v4 CI builds use official NPM published packages. 4.13.0 is the latest.

[ericvergnaud]

ah.

I guess in the meantime you could write:
new CommonToken( [ this, this.input_ ] as any as number, ... ?

[kaby76]

I guess in the meantime you could write:
new CommonToken( [ this, this.input_ ] as any as number, ... ?

Thanks, that works. What a weird type checking, coersion language.

The fix--may be--seems to be with CommonToken.d.ts.

import { Token } from "./Token";
import { CharStream } from "./CharStream";
import { Lexer } from "./Lexer";

export declare class CommonToken extends Token {
    constructor(source: (CharStream | Lexer)[], type: number, channel: number, start: number, stop: number);
    clone(): CommonToken;
    cloneWithType(type: number): CommonToken;
    toString(): string;
}

Good. I'll leave this off here for now as I need to back to cleaning up the horrifying chaos with the grammars-v4/python grammars.

[ericvergnaud]

since that works, the fix is what I initially sent, for CommonToken.d.ts - sorry if I wasn't explicit enough.