Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes produce broken video #1

Closed
davitf opened this issue Jun 14, 2018 · 2 comments
Closed

Changes produce broken video #1

davitf opened this issue Jun 14, 2018 · 2 comments

Comments

@davitf
Copy link

davitf commented Jun 14, 2018

Hi! As you requested in my pull request, I've uploaded a sample video which is fixed correctly by ponchio's master, but when I run it on your master, the output is a broken video. Here are the files.

Running:
./untrunc ok.mp4 broken_sample.mp4

The original code produces the file I've renamed output_original.mp4, and this version produces output_corrupted.mp4.

Let me know if I can help!

@anthwlock
Copy link
Owner

The problem is that the SPS Unit needs to be decoded before the slices are. I added default values for the SpsInfo but this is only a quick fix. Please try if it works for you now.

@davitf
Copy link
Author

davitf commented Jun 27, 2018

It worked! It seemed that the output file was larger than the one generated by ponchio's original code, but I haven't really stopped to analyze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants