Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): add .withResponse() #654

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

RobertCraigie
Copy link
Collaborator

make it more consistent with the rest of the API

@RobertCraigie RobertCraigie marked this pull request as ready for review January 13, 2025 11:45
@RobertCraigie RobertCraigie requested a review from a team as a code owner January 13, 2025 11:45
Copy link

@michael-cohen-io michael-cohen-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this on the other SDKs as well?

@RobertCraigie
Copy link
Collaborator Author

The Python SDK already supports accessing the raw response object with .response and the Go SDK only provides an accumulation helper so the default raw response API will just work :)

@RobertCraigie RobertCraigie merged commit b54477f into next Jan 13, 2025
3 checks passed
@RobertCraigie RobertCraigie deleted the robert/withresponse-on-stream branch January 13, 2025 15:16
stainless-app bot pushed a commit that referenced this pull request Jan 21, 2025
This was referenced Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants