Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: better object fallback behaviour for casting errors #503

Merged
merged 3 commits into from
Sep 9, 2024
Merged

chore: better object fallback behaviour for casting errors #503

merged 3 commits into from
Sep 9, 2024

Conversation

greg84
Copy link
Contributor

@greg84 greg84 commented Aug 21, 2024 •
edited
Loading

@greg84 greg84 requested a review from a team as a code owner August 21, 2024 10:43
@greg84 greg84 mentioned this pull request Aug 21, 2024
Closed
@RobertCraigie RobertCraigie changed the base branch from main to next September 9, 2024 16:27
RobertCraigie
RobertCraigie approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We fixed the error message serialisation separately in this PR but I don't see a reason not to include this fallback behaviour.

@RobertCraigie RobertCraigie changed the title Serialize to error message when an object is passed to castToError chore: better object fallback behaviour for casting errors Sep 9, 2024
@RobertCraigie RobertCraigie merged commit 3660e97 into anthropics:next Sep 9, 2024
4 checks passed
@stainless-app stainless-app bot mentioned this pull request Sep 9, 2024
Merged
stainless-app bot pushed a commit that referenced this pull request Oct 4, 2024
@greg84 @stainless-app
chore: better object fallback behaviour for casting errors (#503)
ab12feb
This was referenced Jan 21, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertCraigie RobertCraigie RobertCraigie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greg84 @RobertCraigie