Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please migrate @aws-sdk/signature-v4 and @aws-sdk/protocol-http in the Bedrock SDK #441

Closed
antstanley opened this issue Jun 21, 2024 · 2 comments · Fixed by #447
Closed

Comments

@antstanley
Copy link

The modules @aws-sdk/protocol-http and @aws-sdk/signature-v4 have been moved to @smithy/signature-v4 and @smithy/protocol-http.

The packages in the @aws-sdk namespace have been marked as deprecated and haven't been updated in a year by AWS, whereas the packages in the @smithy namespace are currently maintained, with regular updates.

Updates:
@aws-sdk/protocol-http - https://www.npmjs.com/package/@aws-sdk/protocol-http?activeTab=versions
@smithy/protocol-http - https://www.npmjs.com/package/@smithy/protocol-http?activeTab=versions

@aws-sdk/signature-v4 - https://www.npmjs.com/package/@aws-sdk/signature-v4?activeTab=versions
@smithy/signature-v4 - https://www.npmjs.com/package/@smithy/signature-v4?activeTab=versions

I was going to submit a PR to resolve this, but I saw that the code base is mainly generated, so wasn't sure where the appropriate place was to fix this.

@dgellow
Copy link

dgellow commented Jun 21, 2024

Thanks @antstanley for reporting this. Assuming you have more context, do I understand correctly the two packages are compatible?

If you still want to submit a PR in this repo, we would appreciate and would reapply the patch on our side to update the SDK

@rattrayalex
Copy link
Collaborator

it looks like this was fixed in #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants