Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG | graph | zoom-out and focus breaks graph edges #31

Closed
5 of 7 tasks
OrbisK opened this issue Feb 10, 2025 · 4 comments · Fixed by #35
Closed
5 of 7 tasks

BUG | graph | zoom-out and focus breaks graph edges #31

OrbisK opened this issue Feb 10, 2025 · 4 comments · Fixed by #35

Comments

@OrbisK
Copy link
Contributor

OrbisK commented Feb 10, 2025

Describe the bug

Image

  1. open reprodcution
  2. zoom out twice
  3. focus and unfocus

Reproduction

https://node-modules.dev/graph#selected=@pnpm/[email protected]&install=@pnpm/core

System Info

System:
    OS: Linux 6.8 Ubuntu 24.04.1 LTS 24.04.1 LTS (Noble Numbat)
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
    Memory: 42.64 GB / 62.58 GB
    Container: Yes
    Shell: 5.9 - /usr/bin/zsh
  Binaries:
    Node: 23.5.0 - ~/.nvm/versions/node/v23.5.0/bin/node
    npm: 10.9.2 - ~/.nvm/versions/node/v23.5.0/bin/npm
    pnpm: 9.15.4 - ~/.nvm/versions/node/v23.5.0/bin/pnpm
    bun: 1.1.42 - ~/.nvm/versions/node/v23.5.0/bin/bun
  Browsers:
    Chrome: 130.0.6723.69

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.

Contributions

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)
@antfu
Copy link
Owner

antfu commented Feb 11, 2025

/cc @serkodev would you like to have a look on this? Thanks

@serkodev
Copy link
Contributor

I tried reproducing this issue on macOS and Windows with both ARM and x64, as well as different screen resolutions, but I couldn’t replicate it.

@OrbisK Does this issue occur every time on your device? If possible, could you provide a recording of the steps to reproduce the issue?

@OrbisK
Copy link
Contributor Author

OrbisK commented Feb 11, 2025

I tried reproducing this issue on macOS and Windows with both ARM and x64, as well as different screen resolutions, but I couldn’t replicate it.

@OrbisK Does this issue occur every time on your device? If possible, could you provide a recording of the steps to reproduce the issue?

  1. open reprodcution
  2. zoom out twice
  3. focus and unfocus
Bildschirmaufzeichnung.vom.2025-02-11.10-13-56.mp4

Tried with FF but #34

@serkodev
Copy link
Contributor

@OrbisK Thanks! I mistakenly thought that “Focus” referred to selecting a graph node. 😂 The problem should be fixed.

@antfu antfu closed this as completed in #35 Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants