Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository description not updating #1165

Closed
chouseknecht opened this issue Sep 21, 2018 · 5 comments
Closed

Repository description not updating #1165

chouseknecht opened this issue Sep 21, 2018 · 5 comments

Comments

@chouseknecht
Copy link
Contributor

chouseknecht commented Sep 21, 2018

Bug Report

SUMMARY

It appears we set the Repository object description during creation, but then never update it during subsequent content imports. The initial value is set to the GitHub repository description, and then remains frozen, despite modifying the repo description on GitHub and modifying the description value in meta/main.yml.

STEPS TO REPRODUCE

GitHub repo description change:

  • Add a new Repository
  • See Repository created
  • Modify the repository description on GitHub
  • Import the Repository on Galaxy
  • See no change has occurred to the description on Galaxy

Metadata description change:

  • Modify the description in meta/main.yml, and push the change to GitHub
  • Import the Repository on Galaxy
  • See that no change has occurred to the Repository description on Galaxy
EXPECTED RESULTS

Since we're working on not being tightly coupled to GitHub, we should update the Repository description with the value found in the Collection metadata. So for a traditional role, modifying meta/main.yml should result in a change to the Repository objects's description value.

ACTUAL RESULTS

No way to update the Repository object description.

@abenokraitis
Copy link

CC: @privateip

@abenokraitis
Copy link

CC: @rcarrillocruz

@chouseknecht
Copy link
Contributor Author

@abenokraitis

Working on a fix for this now. Will get it into production ASAP. In the meantime, if you want us to, we can go through and update ansible-network repos with the current GitHub descr. Just give me the nod to do so.

@abenokraitis
Copy link

Awesome, thanks @chouseknecht ! Based on feedback from @privateip all the text should be updated. Here are the entries that probably need to be manually updated:

https://galaxy.ansible.com/ansible-network/aws
https://galaxy.ansible.com/ansible-network/azure
https://galaxy.ansible.com/ansible-network/openstack
https://galaxy.ansible.com/ansible-network/rhel

@chouseknecht chouseknecht added the status/fix-committed Merged to develop \ release branch label Sep 21, 2018
@chouseknecht chouseknecht reopened this Sep 21, 2018
@chouseknecht chouseknecht added the status/fix-released Fixed in the latest release label Sep 24, 2018
@chouseknecht
Copy link
Contributor Author

@abenokraitis

As requested, manually updated the aws, azure, openstack, and rhel roles with a description value matching the GitHub repository description.

Going forward, please make sure the correct description is set in the meta/main.yml file. The next time any of these roles are imported, the description will be set to the metadata value.

@cutwater cutwater removed the status/fix-committed Merged to develop \ release branch label Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants