From 1a9486721bb8ed0dea38d6bd3479972ae23d1ab4 Mon Sep 17 00:00:00 2001 From: Andrew Crosby Date: Tue, 12 Feb 2019 13:53:36 -0500 Subject: [PATCH] Fix updating role dependencies when empty (#1545) Signed-off-by: Andrew Crosby --- galaxy/worker/importers/role.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/galaxy/worker/importers/role.py b/galaxy/worker/importers/role.py index 329544c98..d2a16e9d9 100644 --- a/galaxy/worker/importers/role.py +++ b/galaxy/worker/importers/role.py @@ -159,11 +159,9 @@ def _add_dependencies(self, role, dependencies): if role.role_type not in (constants.RoleType.CONTAINER, constants.RoleType.ANSIBLE): return - if not dependencies: - return self.log.info('Adding role dependencies') new_deps = [] - for dep in dependencies: + for dep in dependencies or []: try: dep_role = models.Content.objects.get( namespace__name=dep.namespace, name=dep.name)