Add proxy support in custom venv container fixes #5756 #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
seems pretty reasonable to me - any thoughts @matburt ? |
ryanpetrello
approved these changes
Feb 3, 2020
|
Build succeeded (gate pipeline).
|
Zokormazo
pushed a commit
that referenced
this pull request
May 6, 2022
Fix broken job WFJT details when related JT is deleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes #5756. It supports the http_proxy, https_proxy, and no_proxy environment variables in the init container that generates custom virtual environments. Pip and yum will pick up on these environment variables automatically and send their traffic through the proxies.
ISSUE TYPE
COMPONENT NAME