Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "msg": "missing required arg: config_manager_text" #88

Merged

Conversation

NilashishC
Copy link
Member

Signed-off-by: NilashishC <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Signed-off-by: NilashishC <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@NilashishC NilashishC requested a review from justjais January 18, 2019 11:25
Copy link
Member

@trishnaguha trishnaguha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If config_manager_file is passed, we would want to support config_manager_file also.

In load task:

- name: load configuration file contents
  set_fact:
    config_manager_text: "{{ lookup('config_template', config_manager_file) | join('\n') }}"
  when: config_manager_file is defined

@NilashishC
Copy link
Member Author

@samccann fixed the docs issue you pointed to.

Copy link

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs portion LGTM

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 81718b3 into ansible-network:devel Jan 21, 2019
@NilashishC NilashishC deleted the fix_docs branch January 21, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants