Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improve examples on overriding deployment resources #29

Open
oraNod opened this issue Dec 12, 2024 · 2 comments
Open

Docs: Improve examples on overriding deployment resources #29

oraNod opened this issue Dec 12, 2024 · 2 comments
Assignees
Labels
docs Improvements or additions to documentation

Comments

@oraNod
Copy link
Contributor

oraNod commented Dec 12, 2024

Follows up on #20 (comment)

Purpose is to improve documentation in README at

### Controller

While the example of the replica is valid. This is not really a common scenario to customize the operator replica (maybe to scale up/scale down). One more common use case is to specify a different container image for each container as seen in #17 or #27 to cover disconnected/restricted environments.
Another useful example would be to provide an example for setting up resource requests and limits, this would cover #14.

@oraNod oraNod added the docs Improvements or additions to documentation label Dec 12, 2024
@oraNod oraNod changed the title Docs: Improve Docs: Improve examples on overriding deployment resources Dec 12, 2024
@miles-w-3
Copy link
Collaborator

Adding additional context from the other thread as well, This is more of a feature because the naive override approach would have to be overriding the entire container list since helm does not support merging lists together.

The alternative is to improve the templating logic to offer a containerConfigOverride key or something similar where you can provide a key which matches a container name and the values you want to layer in, and then helm template logic to loop through the containers list from the original operator and splice the override configs in. This is something I can work on once we get releases going

#20 (comment)

@miles-w-3
Copy link
Collaborator

Will be closed in #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants