Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Validate timeout function delivered by ZOAU #377

Closed
ddimatos opened this issue Aug 19, 2022 · 2 comments · Fixed by #391
Closed

[Enhancement] Validate timeout function delivered by ZOAU #377

ddimatos opened this issue Aug 19, 2022 · 2 comments · Fixed by #391
Assignees
Labels
Enhancement Enhancement to existing collection content Resolved The issue is resolved, authors issue has been addressed

Comments

@ddimatos
Copy link
Collaborator

At the time of development this timout parameter was not implemented although conveyed so it must be tested after the latest zoau ASM updates.

See file zos_operator.py
See lines 298

    if params.get("wait"):
        wait = params.get("wait_time_s")
        if wait:
            kwargs.update({"timeout": "{0}".format(wait)})
            kwargs.update({"parameters": "ISFDELAY={0}".format(wait)})
            # it *appears* IFSdelay is passing through correctly... did 1x-4x tests 0 to 20 seconds
@ddimatos ddimatos added the Enhancement Enhancement to existing collection content label Aug 19, 2022
@ddimatos ddimatos self-assigned this Aug 19, 2022
@ddimatos
Copy link
Collaborator Author

Also need to enabled the test case line 100

# def test_zos_operator_positive_verbose_with_full_delay(ansible_zos_module):
#     hosts = ansible_zos_module
#     startmod = time.time()
#     results = hosts.all.zos_operator(
#         cmd="d u,all", verbose=True, wait_time_s=5, wait=True
#     )
#     endmod = time.time()
#     timediff = endmod - startmod
#     assert timediff > 4
#     for result in results.contacted.values():
#         assert result["rc"] == 0
#         assert result.get("changed") is True
#         assert result.get("content") is not None

@ddimatos ddimatos added the In Progress This issue is under review by a team member. label Sep 2, 2022
@ddimatos ddimatos moved this to 🏗 In progress in IBM Ansible z/OS Core Collection Sep 2, 2022
@ddimatos ddimatos added Resolved The issue is resolved, authors issue has been addressed and removed In Progress This issue is under review by a team member. labels Sep 7, 2022
@ddimatos
Copy link
Collaborator Author

One draw back to Git closing issues when you tag them in a PR and the PR completes is that we don't have the opportunity to comment here, anyhow, pull request #391 addresses this issue and a few others as well, there is a test case added that waits 30 seconds

@ddimatos ddimatos moved this from 🏗 In progress to ✅ Done in IBM Ansible z/OS Core Collection Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancement to existing collection content Resolved The issue is resolved, authors issue has been addressed
Projects
Development

Successfully merging a pull request may close this issue.

1 participant