From e626a94a6261731d0e1cd29c30bf65a3c577afb6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20M=C3=BCnch?= Date: Mon, 12 Jun 2023 21:34:04 +0200 Subject: [PATCH 1/3] Fixes #179: Add missing /tool/e-mail parameter "tls" In the [documentation](https://help.mikrotik.com/docs/display/ROS/E-mail#Email-Properties) the parameter "tls" is mentioned but it cannot be used. The old "start-tls" parameter is not mentioned there (only on the [old documentation](https://wiki.mikrotik.com/wiki/Manual:Tools/email#Properties)). Trying to use the paramter "tls" lead to the erro message `FAILED! => {"changed": false, "msg": "Unknown key \"tls\"."}`. --- plugins/module_utils/_api_data.py | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/module_utils/_api_data.py b/plugins/module_utils/_api_data.py index 0d3e82f7..59e5b5c5 100644 --- a/plugins/module_utils/_api_data.py +++ b/plugins/module_utils/_api_data.py @@ -2451,6 +2451,7 @@ def join_path(path): 'password': KeyInfo(default=''), 'port': KeyInfo(default=25), 'start-tls': KeyInfo(default=False), + 'tls': KeyInfo(default=False), 'user': KeyInfo(default=''), }, ), From 1b1d5f3cbac664d1c6d69df394a0622e78e1b04b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20M=C3=BCnch?= Date: Thu, 15 Jun 2023 09:07:04 +0200 Subject: [PATCH 2/3] Add changelog fragment --- changelogs/fragments/180-fix-tls-in-tool-email.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/180-fix-tls-in-tool-email.yml diff --git a/changelogs/fragments/180-fix-tls-in-tool-email.yml b/changelogs/fragments/180-fix-tls-in-tool-email.yml new file mode 100644 index 00000000..de6551cf --- /dev/null +++ b/changelogs/fragments/180-fix-tls-in-tool-email.yml @@ -0,0 +1,2 @@ +bugfixes: + - community.routeros.api_modify - fix missing parameter ``tls`` for ``/tool/e-mail``. The error ``FAILED! => {"changed": false, "msg": "Unknown key \"tls\"."}`` was raised (https://github.com/ansible-collections/community.routeros/issues/179). From b03f6621da2620f6360bf08a7f70091cbb18b7d3 Mon Sep 17 00:00:00 2001 From: derdeagle Date: Fri, 16 Jun 2023 08:12:47 +0200 Subject: [PATCH 3/3] Update changelogs/fragments/180-fix-tls-in-tool-email.yml As suggested by felixfontein Co-authored-by: Felix Fontein --- changelogs/fragments/180-fix-tls-in-tool-email.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/fragments/180-fix-tls-in-tool-email.yml b/changelogs/fragments/180-fix-tls-in-tool-email.yml index de6551cf..0a694985 100644 --- a/changelogs/fragments/180-fix-tls-in-tool-email.yml +++ b/changelogs/fragments/180-fix-tls-in-tool-email.yml @@ -1,2 +1,2 @@ bugfixes: - - community.routeros.api_modify - fix missing parameter ``tls`` for ``/tool/e-mail``. The error ``FAILED! => {"changed": false, "msg": "Unknown key \"tls\"."}`` was raised (https://github.com/ansible-collections/community.routeros/issues/179). + - api_modify, api_info - add missing parameter ``tls`` for the ``tool e-mail`` path (https://github.com/ansible-collections/community.routeros/issues/179, https://github.com/ansible-collections/community.routeros/pull/180).